Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

jaeger per-user force-tracing does not work correctly for /sendToDevice and /keys/upload #13567

Closed
richvdh opened this issue Aug 19, 2022 · 1 comment · Fixed by #13574
Closed

jaeger per-user force-tracing does not work correctly for /sendToDevice and /keys/upload #13567

richvdh opened this issue Aug 19, 2022 · 1 comment · Fixed by #13574
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@richvdh
Copy link
Member

richvdh commented Aug 19, 2022 •
edited
Loading

The on_POST handlers for these two endpoints have some overenthusiastic jaeger annotations (@trace_with_opname). This means that there is an extra layer of spans between the servlet span (which logs the request id) and the call to get_user_by_req (which enables tracing on the active span if the user has force-tracing enabled).
@richvdh richvdh changed the title jaeger force-tracing does not work for /sendToDevice and /upload_keys jaeger force-tracing does not work correctly for /sendToDevice and /upload_keys Aug 19, 2022
@richvdh richvdh changed the title jaeger force-tracing does not work correctly for /sendToDevice and /upload_keys jaeger force-tracing does not work correctly for /sendToDevice and /upload_keys Aug 19, 2022
@richvdh richvdh changed the title jaeger force-tracing does not work correctly for /sendToDevice and /upload_keys jaeger per-user force-tracing does not work correctly for /sendToDevice and /upload_keys Aug 19, 2022
@richvdh
Copy link
Member Author

richvdh commented Aug 19, 2022

The solution is just to remove the @trace_with_opnames. They are entirely redundant since we already have spans for the servlet.

@ara4n ara4n mentioned this issue Aug 19, 2022
Closed
@anoadragon453 anoadragon453 mentioned this issue Aug 19, 2022
Merged
@anoadragon453 anoadragon453 changed the title jaeger per-user force-tracing does not work correctly for /sendToDevice and /upload_keys jaeger per-user force-tracing does not work correctly for /sendToDevice and /keys/upload Aug 19, 2022
@anoadragon453 anoadragon453 added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant opentracing spans for /sendToDevice and /keys/upload matrix-org/synapse
2 participants
@anoadragon453 @richvdh