Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Cargo.lock missing in release tarball of 1.68.0rc2 #13907

Closed
NickCao opened this issue Sep 26, 2022 · 2 comments · Fixed by #13909
Closed

Cargo.lock missing in release tarball of 1.68.0rc2 #13907

NickCao opened this issue Sep 26, 2022 · 2 comments · Fixed by #13909
Assignees
Labels
X-Release-Blocker Must be resolved before making a release Z-Release Issues tracking a Synapse release

Comments

@NickCao
Copy link

NickCao commented Sep 26, 2022

Description

Cargo.lock should be included in the release tarball for reproducible builds.

Steps to reproduce

curl -sL https://github.com/matrix-org/synapse/releases/download/v1.68.0rc2/matrix-synapse-1.68.0rc2.tar.gz | tar tzf - | grep Cargo

Homeserver

not applicable

Synapse Version

1.68.0rc2

Installation Method

No response

Platform

not applicable

Relevant log output

not applicable

Anything else that would be useful to know?

No response

@DMRobertson DMRobertson added X-Release-Blocker Must be resolved before making a release Z-Release Issues tracking a Synapse release and removed X-Release-Blocker Must be resolved before making a release labels Sep 26, 2022
@DMRobertson
Copy link
Contributor

I think we need a top-level Cargo.lock here?

synapse/pyproject.toml

Lines 88 to 90 in 11ebcc8

{ path = "Cargo.toml", format = "sdist" },
{ path = "rust/Cargo.toml", format = "sdist" },
{ path = "rust/Cargo.lock", format = "sdist" },

@DMRobertson DMRobertson added the X-Release-Blocker Must be resolved before making a release label Sep 26, 2022
@NickCao
Copy link
Author

NickCao commented Sep 26, 2022

As this whole project is a single cargo workspace, there should be one and only one top-level Cargo.lock for all member crates.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Release-Blocker Must be resolved before making a release Z-Release Issues tracking a Synapse release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants