Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Complement TestPartialStateJoin/joined_members_blocks_during_partial_state_join is flakey #13989

Closed
squahtx opened this issue Sep 30, 2022 · 1 comment
Labels
A-Federated-Join joins over federation generally suck A-Testing Issues related to testing in complement, synapse, etc T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact

Comments

@squahtx
Copy link
Contributor

squahtx commented Sep 30, 2022

eg. https://github.com/matrix-org/synapse/actions/runs/3155155132/jobs/5133560136

TestPartialStateJoin/joined_members_blocks_during_partial_state_join (0s)
      client.go:604: [CSAPI] POST hs1/_matrix/client/v3/register => 200 OK (34.412248ms)
      client.go:604: [CSAPI] GET hs1/_matrix/client/v3/capabilities => 200 OK (5.248592ms)
      server.go:165: Creating room !0:host.docker.internal:37051 with version 9
      federation_room_join_partial_state_test.go:2697: Registered state_ids handler for event $4tSrit43m-GqqgoYz3efGvu-a8fHY7f_vQ_qra0V6iE
      federation_room_join_partial_state_test.go:2738: Registered /state handler for event $4tSrit43m-GqqgoYz3efGvu-a8fHY7f_vQ_qra0V6iE
      client.go:604: [CSAPI] POST hs1/_matrix/client/v3/join/!0:host.docker.internal:37051 => 200 OK (43.623833ms)
      federation_room_join_partial_state_test.go:2610: /join request completed
      client.go:604: [CSAPI] GET hs1/_matrix/client/v3/rooms/!0:host.docker.internal:37051/joined_members => 200 OK (11.792982ms)
      federation_room_join_partial_state_test.go:2652: Waiting for /state_ids request: timed out after 5.000000 seconds.
  panic: send on closed channel
  
  goroutine 3280 [running]:
  github.com/matrix-org/complement/tests.TestPartialStateJoin.func28.1()
  	/home/runner/work/synapse/synapse/complement/tests/federation_room_join_partial_state_test.go:1340 +0x12b
  created by github.com/matrix-org/complement/tests.TestPartialStateJoin.func28
  	/home/runner/work/synapse/synapse/complement/tests/federation_room_join_partial_state_test.go:1338 +0x27d
@squahtx squahtx added A-Federated-Join joins over federation generally suck Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact A-Testing Issues related to testing in complement, synapse, etc T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Sep 30, 2022
@squahtx
Copy link
Contributor Author

squahtx commented Oct 5, 2022

The room ID !0:host.docker.internal:37051 appears to be reused across tests, with the same Synapse deployment.

For now, let's assume that this has the same cause as #13975.

@squahtx squahtx closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Federated-Join joins over federation generally suck A-Testing Issues related to testing in complement, synapse, etc T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact
Projects
None yet
Development

No branches or pull requests

1 participant