Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Complement TestPartialStateJoin/Outgoing_device_list_updates/Device_list_updates_reach_incorrectly_absent_servers_once_partial_state_join_completes_even_though_remote_server_left_room is flakey? #14853

Closed
DMRobertson opened this issue Jan 16, 2023 · 1 comment · Fixed by matrix-org/complement#627
Closed

Complement TestPartialStateJoin/Outgoing_device_list_updates/Device_list_updates_reach_incorrectly_absent_servers_once_partial_state_join_completes_even_though_remote_server_left_room is flakey? #14853

DMRobertson opened this issue Jan 16, 2023 · 1 comment · Fixed by matrix-org/complement#627
Labels
A-Device-List-Tracking Telling clients about other devices. Often related to E2EE. A-Federated-Join joins over federation generally suck O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Flake Tests that give intermittent failures
Milestone
Remaining faster ...

Comments

@DMRobertson
Copy link
Contributor

https://github.com/matrix-org/synapse/actions/runs/3914401184/jobs/6691457993

I think the line that errors is https://github.com/matrix-org/complement/blob/fe5887f0907b88a9c562a67009200b8b7af26545/tests/federation_room_join_partial_state_test.go#L2184
@DMRobertson DMRobertson added A-Federated-Join joins over federation generally suck A-Device-List-Tracking Telling clients about other devices. Often related to E2EE. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Flake Tests that give intermittent failures S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 16, 2023
@DMRobertson DMRobertson mentioned this issue Jan 16, 2023
Merged
@DMRobertson
Copy link
Contributor Author

Possibly a duplicate of #13977?

@squahtx squahtx changed the title Complement Outgoing_device_list_updates/Device_list_updates_reach_incorrectly_absent_servers_once_partial_state_join_completes_even_though_remote_server_left_room is flakey? Complement TestPartialStateJoin/Outgoing_device_list_updates/Device_list_updates_reach_incorrectly_absent_servers_once_partial_state_join_completes_even_though_remote_server_left_room is flakey? Feb 16, 2023
@DMRobertson DMRobertson linked a pull request Mar 16, 2023 that will close this issue
Deflake faster joins device list tests by waiting for leave event matrix-org/complement#627
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Device-List-Tracking Telling clients about other devices. Often related to E2EE. A-Federated-Join joins over federation generally suck O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Flake Tests that give intermittent failures
Projects
None yet
Milestone
Remaining faster remote join work
Development

Successfully merging a pull request may close this issue.

Deflake faster joins device list tests by waiting for leave event matrix-org/complement
2 participants
@erikjohnston @DMRobertson