Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Failed to find memberships for ["@user:...."] in partial state room !... in the auth events of ["$..."]. #15221

Closed
squahtx opened this issue Mar 7, 2023 · 2 comments · Fixed by #15232
Closed

Failed to find memberships for ["@user:...."] in partial state room !... in the auth events of ["$..."]. #15221

squahtx opened this issue Mar 7, 2023 · 2 comments · Fixed by #15232
Assignees
@squahtx
Labels
A-Federated-Join joins over federation generally suck A-Sync defects related to /sync O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Milestone
Remaining faster ...

Comments

@squahtx
Copy link
Contributor

squahtx commented Mar 7, 2023

https://sentry.tools.element.io/organizations/element/issues/63004/?project=2&query=is%3Aunresolved

When pushing events in partial state rooms down incremental /sync, we try to find the m.room.member state event for their sender by digging through their auth events, so that we can present the membership to the client. Events usually have a membership event in their auth events, with the exception of the m.room.create event and a user's first join into the room.

When implementing #13477, we forgot to consider the exceptions.
@squahtx squahtx added A-Federated-Join joins over federation generally suck A-Sync defects related to /sync S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 7, 2023
@DMRobertson
Copy link
Contributor

What's the impact of this---does this block incremental syncs?

@squahtx
Copy link
Contributor Author

squahtx commented Mar 8, 2023

Nope, it's just an error-level log message.

@squahtx squahtx self-assigned this Mar 8, 2023
@squahtx squahtx mentioned this issue Mar 8, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@squahtx squahtx

Labels
A-Federated-Join joins over federation generally suck A-Sync defects related to /sync O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
Remaining faster remote join work
Development

Successfully merging a pull request may close this issue.

Faster joins: Fix spurious errors on incremental sync matrix-org/synapse
2 participants
@squahtx @DMRobertson