Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Allow endpoint: _matrix/client/<>/register/available on workers #15242

Closed
999lakhisidhu opened this issue Mar 10, 2023 · 3 comments · Fixed by #15268
Closed

Allow endpoint: _matrix/client/<>/register/available on workers #15242

999lakhisidhu opened this issue Mar 10, 2023 · 3 comments · Fixed by #15268
Labels
A-Registration Creating an account A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@999lakhisidhu
Copy link
Contributor

999lakhisidhu commented Mar 10, 2023 •
edited
Loading

This endpoint is not working with worker configuration. , it has to be routed through the main process . can we enable it please, on worker configuration as well
@DMRobertson
Copy link
Contributor

Are you sure about this? (Which Synapse version are you running?)

The worker documentation lists
^/_matrix/client/(r0|v3|unstable)/register$ as something that can be handled by a generic worker.

@DMRobertson DMRobertson added A-Workers Problems related to running Synapse in Worker Mode (or replication) T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. A-Registration Creating an account S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Mar 10, 2023
@dklimpel
Copy link
Contributor

It is only available on main process UsernameAvailabilityRestServlet:

synapse/synapse/rest/client/register.py

Lines 956 to 959 in ce54477

if hs.config.worker.worker_app is None:
EmailRegisterRequestTokenRestServlet(hs).register(http_server)
MsisdnRegisterRequestTokenRestServlet(hs).register(http_server)
UsernameAvailabilityRestServlet(hs).register(http_server)

@999lakhisidhu
Copy link
Contributor Author

@DMRobertson yes i am sure , v1.79.0rc1 , i tried with this version

This was referenced Mar 14, 2023
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Registration Creating an account A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load /register/available endpoint on workers realtyem/synapse-old
3 participants
@dklimpel @DMRobertson @999lakhisidhu