Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Gracefully drop MSC2716 related tables (incrementally import history) #15786

Closed
MadLittleMods opened this issue Jun 15, 2023 · 1 comment · Fixed by #16268 or #16522
Closed

Gracefully drop MSC2716 related tables (incrementally import history) #15786

MadLittleMods opened this issue Jun 15, 2023 · 1 comment · Fixed by #16268 or #16522
Assignees
Labels
A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases

Comments

@MadLittleMods
Copy link
Contributor

Gracefully drop MSC2716 related tables (incrementally import history) in multiple steps/phases.

Step 1

In one Synapse version, stop writing to any MSC2716 related tables. The normal steps to gracefully drop a table usually include a step to first switch over reads but keep writing but since this is a experimental feature, we don't need to worry about the feature working we can just stop reading and writing in the same step.

This is being tackled in #15748

Step 2

In the Synapse release after the first step ships, we can bump SCHEMA_COMPAT_VERSION and drop the tables altogether.

Relevant tables to drop:

-- Drop tables related to MSC2716 since the implementation is being removed
DROP TABLE insertion_events;
DROP TABLE insertion_event_edges;
DROP TABLE insertion_event_extremities;
DROP TABLE batch_events;
@MadLittleMods MadLittleMods added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases labels Jun 15, 2023
@MadLittleMods MadLittleMods added this to the Revisit: Next Month milestone Jun 15, 2023
@MadLittleMods MadLittleMods added the A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db label Jun 20, 2023
@erikjohnston erikjohnston removed this from the Revisit: Next Week milestone Aug 3, 2023
@clokep
Copy link
Member

clokep commented Oct 18, 2023

See #16465

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Database DB stuff like queries, migrations, new/remove columns, indexes, unexpected entries in the db T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Future-Maintenance Things that can't yet be done, but will need cleaning up in a couple of months/releases
Projects
None yet
3 participants