Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Enforce Server-Server 4.1 PDU fields #3162

Closed
jevolk opened this issue May 1, 2018 · 1 comment
Closed

Enforce Server-Server 4.1 PDU fields #3162

jevolk opened this issue May 1, 2018 · 1 comment

Comments

@jevolk
Copy link

jevolk commented May 1, 2018

The specification states in server-server 4.1 PDU fields:

depth | Integer | Required. The maximum depth of the prev_events, plus one

Synapse accepts events with depths that are not the maximum depth of the prev_events, plus one. The solution is to only accept events with depths that are the maximum depth of the prev_events, plus one.
@richvdh
Copy link
Member

richvdh commented May 12, 2018

dup #1254, though really we should just not rely on depth at all.

@richvdh richvdh closed this as completed May 12, 2018
@turt2live turt2live mentioned this issue Jul 10, 2018
Closed
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @jevolk