Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

get_keys_from_store should do one big lookup, not hundreds of tiny ones #3818

Closed
richvdh opened this issue Sep 6, 2018 · 2 comments
Closed

get_keys_from_store should do one big lookup, not hundreds of tiny ones #3818

richvdh opened this issue Sep 6, 2018 · 2 comments
Labels
A-Federation A-Performance Performance, both client-facing and admin-facing z-p2 (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Sep 6, 2018 •
edited
Loading

We need to look up keys for 1136 servers to join #riot. getting each one with its own SELECT is, uh, inefficient.

It's not a huge effect, but it doesn't make joins any quicker.
@richvdh richvdh mentioned this issue Sep 6, 2018
Closed
@richvdh
Copy link
Member Author

richvdh commented Sep 6, 2018

Related: #3819

@richvdh richvdh mentioned this issue Sep 7, 2018
Closed
@hawkowl hawkowl added federation-meltdown A-Performance Performance, both client-facing and admin-facing labels Sep 14, 2018
@neilisfragile neilisfragile added the z-p2 (Deprecated Label) label Oct 5, 2018
@richvdh
Copy link
Member Author

richvdh commented May 24, 2019

fixed by #5030

@richvdh richvdh closed this as completed May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Federation A-Performance Performance, both client-facing and admin-facing z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@neilisfragile @richvdh @hawkowl @DMRobertson