Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Joining rooms and backfill are broken if you change your signing key and use the old ID #4012

Closed
richvdh opened this issue Oct 5, 2018 · 8 comments
Labels
A-Federation S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-p2 (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Oct 5, 2018

If you create a bunch of state events, and then change the key and use the same ID, it can cause difficulty for new servers trying to join or backfill such rooms, because the signatures appear invalid

@richvdh
Copy link
Member Author

richvdh commented Oct 5, 2018

this is somewhat related to https://github.com/matrix-org/matrix-doc/issues/1685.

@richvdh
Copy link
Member Author

richvdh commented Oct 5, 2018

@neilisfragile neilisfragile added A-Federation z-p2 (Deprecated Label) labels Oct 9, 2018
@richvdh
Copy link
Member Author

richvdh commented Nov 9, 2018

The solution to this is to use a better identifier as the key ID (such as a hash of the public key, or the key itself for ed25519), so that servers can't claim that two different keys are both called ed25519:auto.

@richvdh
Copy link
Member Author

richvdh commented Sep 23, 2020

dup matrix-org/matrix-spec#807

@richvdh richvdh closed this as completed Sep 23, 2020
@richvdh
Copy link
Member Author

richvdh commented Nov 20, 2020

matrix-org/matrix-spec#807 got resolved by #8350, but I'm not sure joining rooms got the same treatment.

@richvdh richvdh reopened this Nov 20, 2020
@richvdh richvdh added S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Dec 23, 2021
@richvdh
Copy link
Member Author

richvdh commented Dec 23, 2021

Unverifiable events no longer stop you joining a room altogether (though they can still cause inconsistent state, obviously).

@richvdh
Copy link
Member Author

richvdh commented May 19, 2022

dup matrix-org/matrix-spec#807

I wish I knew what this was actually trying to link to. I'm pretty sure it wasn't that.

@turt2live
Copy link
Member

dup matrix-org/matrix-spec#807

I wish I knew what this was actually trying to link to. I'm pretty sure it wasn't that.

Thanks to email history, we've discovered that it's actually #3121

Best guess is github guessed wrong on the numbered reference when 3121 moved from matrix-doc to matrix-spec (evidenced by https://github.com/matrix-org/matrix-doc/issues/3121 becoming matrix-org/matrix-spec#807 )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Federation S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-p2 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

3 participants