Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Transfer widgets on room upgrade #4994

Open
turt2live opened this issue Apr 2, 2019 · 4 comments
Open

Transfer widgets on room upgrade #4994

turt2live opened this issue Apr 2, 2019 · 4 comments
Labels
A-Room-Upgrades O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@turt2live
Copy link
Member

because this seems useful, even if no one has asked for it

@neilisfragile neilisfragile added A-Room-Upgrades z-p2 (Deprecated Label) labels Apr 3, 2019
@anoadragon453
Copy link
Member

I suppose we don't want to transfer all of the events (adding/removing widgets over and over) but instead just those that haven't been paired with a deletion event (and thus those that are actually active in the room). Not sure if there's a quick way to do this or we just have to compare all the events.

@neilisfragile neilisfragile added the z-bug (Deprecated Label) label Apr 3, 2019
@turt2live
Copy link
Member Author

Should be a trivial thing to grab the state events and filter out the ones missing a url field (indicating deletion)

@anoadragon453
Copy link
Member

TIL about current_state.

@anoadragon453
Copy link
Member

So #5000 got pegged for now as transferring widgets on room upgrade may cause a lot of things to be broken silently, which is worse than just not doing it in the first place.

@anoadragon453 anoadragon453 removed their assignment Apr 9, 2019
@DMRobertson DMRobertson added S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed z-bug (Deprecated Label) z-p2 (Deprecated Label) labels Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Room-Upgrades O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

5 participants