Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't default to an invalid sqlite config if no database configuration is provided #6249

Closed
babolivier opened this issue Oct 24, 2019 · 1 comment
Closed

Don't default to an invalid sqlite config if no database configuration is provided #6249

babolivier opened this issue Oct 24, 2019 · 1 comment
Labels
z-p2 (Deprecated Label)

Comments

@babolivier
Copy link
Contributor

Currently, if no database configuration is provided, Synapse will default that configuration to {"name": "sqlite3", "args": {}} which will produce an error (because it's missing a database argument). Instead, it should raise a ConfigError explaining that this part of the configuration is required.
@neilisfragile neilisfragile added z-p2 (Deprecated Label) enhancement labels Nov 6, 2019
@nekatak nekatak mentioned this issue Dec 19, 2019
Merged
4 tasks
@richvdh
Copy link
Member

richvdh commented Mar 26, 2020

fixed by #6573

@richvdh richvdh closed this as completed Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neilisfragile @richvdh @babolivier