This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Clean up startup for the pusher #6558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`str.decode()` doesn't exist on python3, so presumably this code was doing nothing
When we get a row with unparsable json, drop the row, rather than returning a row with null `data`, which will then cause an explosion later on.
Log the ID to help us understand the problem
We know we'll have a `data` member, since that comes from the database. What we *don't* know is if that is a dict, and if that has a `brand` member, and if that member is a string.
erikjohnston
approved these changes
Dec 17, 2019
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'd6752ce5d': Clean up startup for the pusher (#6558)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several separate but related commits here; suggest reviewing them independently. It's all about trying to stop the pusher from logging a load of exceptions at startup.