Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Prevent upgraded rooms from ever reappearing in the room directory #6638

Closed
aaronraimist opened this issue Jan 6, 2020 · 4 comments
Closed

Prevent upgraded rooms from ever reappearing in the room directory #6638

aaronraimist opened this issue Jan 6, 2020 · 4 comments
Labels
A-Room-Directory T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@aaronraimist
Copy link
Contributor

#4948 happens but it doesn't stop the room from getting state reset back into the directory. The old #synapse:matrix.org is back in the matrix.org room directory.
@richvdh
Copy link
Member

richvdh commented Jan 6, 2020

I don't think this is a state-reset: I think the upgrade of #synapse just (significantly) predates the fix to #4948.

@richvdh richvdh mentioned this issue Jan 6, 2020
Merged
@aaronraimist
Copy link
Contributor Author

aaronraimist commented Jan 7, 2020 •
edited
Loading

Yes it did but I’m pretty sure the old room had been manually removed from from the room directory.

@richvdh
Copy link
Member

richvdh commented Jan 7, 2020

I can't see any evidence of that, from the database.

@richvdh richvdh closed this as completed Jan 12, 2020
@aaronraimist aaronraimist mentioned this issue Mar 12, 2020
Closed
@MadLittleMods MadLittleMods added A-Room-Directory T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Sep 6, 2022
@MadLittleMods
Copy link
Contributor

Still a problem, see #10075

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Room-Directory T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MadLittleMods @richvdh @aaronraimist