Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

tests.test_phone_home.PhoneHomeStatsTestCase.test_performance_100 fails on Raspberry Pi 2 #6676

Closed
anoadragon453 opened this issue Jan 10, 2020 · 4 comments
Labels
z-bug (Deprecated Label) z-p3 (Deprecated Label)

Comments

@anoadragon453
Copy link
Member

The tests.test_phone_home.PhoneHomeStatsTestCase.test_performance_100 test fails on a raspberry pi 2.

twisted.trial.unittest.FailTest: 107 ~== 100

Likely related to performance issues but it seems their homeserver is working well enough otherwise.

Synapse v1.8.0

@neilisfragile neilisfragile added z-bug (Deprecated Label) z-p3 (Deprecated Label) labels Jan 22, 2020
@a22sc
Copy link

a22sc commented Apr 2, 2020

Same on BananaPi M3 with latest develop.
Any suggestions?

[FAIL]
Traceback (most recent call last):
  File "/home/bpiusr/.cache/pikaur/build/matrix-synapse-git/src/synapse/tests/test_phone_home.py", line 51, in test_performance_100
    self.assertApproximates(stats["cpu_average"], 100, tolerance=2.5)
  File "/usr/lib/python3.8/site-packages/twisted/trial/_synctest.py", line 564, in assertApproximates
    raise self.failureException(msg or "%s ~== %s" % (first, second))
twisted.trial.unittest.FailTest: 107 ~== 100

tests.test_phone_home.PhoneHomeStatsTestCase.test_performance_100

@richvdh
Copy link
Member

richvdh commented Apr 2, 2020

this is code that was added in #6318. It looks like if we moved this code to near the start of the function, it would be more reliable.

Don't think it's affecting anything other than the tests though

@a22sc
Copy link

a22sc commented Apr 2, 2020

any idea how i can pass this test anyway, or install synapse ignoring this one?

thanks

@clokep
Copy link
Member

clokep commented Jun 5, 2020

I'm going to close this since #7634 implements the suggestion above. Please shout if this is still an issue!

@clokep clokep closed this as completed Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-bug (Deprecated Label) z-p3 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

5 participants