This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix purge_room admin API #6711
Merged
Fix purge_room admin API #6711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/fix_purge_room_2
branch
from
5b5c612 to
e0c3d42
Compare
richvdh
reviewed
Jan 15, 2020
| @@ -337,7 +337,7 @@ def test_purge_room(self): | |||
| "local_invites", | |||
| "room_account_data", | |||
| "room_tags", | |||
| "state_groups", | |||
| # "state_groups", # Current impl leaves orphaned state groups around. | |||
There was a problem hiding this comment.
Is this the likely cause of #6566?
There was a problem hiding this comment.
Ah, yup, as we don't delete by room_id on state_groups but indirect via the events table. That coupled with the fact that we now are more proactive with creating state groups that aren't referenced by events means we do end up with some orphaned bits and pieces.
There was a problem hiding this comment.
Ah, yup, as we don't delete by room_id on state_groups
Why not?
There was a problem hiding this comment.
Mainly so that we could avoid adding another index to state_groups, but I think we might just want to do that anyway.
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '19a1aac48': Fix purge_room admin API (#6711)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6707