Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Message retention purge jobs can incorrectly think there's no event to purge from a room #6713

Closed
babolivier opened this issue Jan 15, 2020 · 1 comment
Assignees
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@babolivier
Copy link
Contributor

babolivier commented Jan 15, 2020

An interesting bug I found while investigating #6683:

When figuring out which topological token to start a purge job at, we need to do the following:

  1. Figure out a timestamp before which events will be purged
  2. Select the first stream ordering after that timestamp
  3. Select info about the first event after that stream ordering
  4. Build a topological token from that info

In some situations (e.g. quiet rooms with a short max_lifetime), there not be an event after the stream ordering at step 3, therefore we abort the purge with the error No event found.

@babolivier babolivier self-assigned this Jan 15, 2020
@neilisfragile neilisfragile added z-bug (Deprecated Label) z-p2 (Deprecated Label) labels Jan 22, 2020
@babolivier
Copy link
Contributor Author

Fixed in #6714

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

2 participants