Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

[user admin api] You can accidentally deactivate a user by setting the "deactivated" param to a str #6989

Closed
anoadragon453 opened this issue Feb 25, 2020 · 1 comment
Closed

[user admin api] You can accidentally deactivate a user by setting the "deactivated" param to a str #6989

anoadragon453 opened this issue Feb 25, 2020 · 1 comment
Assignees
@anoadragon453

Comments

@anoadragon453
Copy link
Member

If you send the following to PUT /_synapse/admin/v2/users/@bob:test:

{
  "deactivated": "false"
}

You will still deactivate the user, because strings are truthy :)
@anoadragon453 anoadragon453 self-assigned this Feb 25, 2020
@anoadragon453 anoadragon453 mentioned this issue Feb 25, 2020
Merged
@anoadragon453
Copy link
Member Author

Fixed by #6990

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anoadragon453 anoadragon453

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anoadragon453