This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Enforce MSC2209: auth rules for notifications in power level event #7502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
clokep/notif-auth-rules
branch
from
f02ea48 to
466fff9
Compare
richvdh
approved these changes
May 14, 2020
This was referenced May 14, 2020
phil-flex
pushed a commit
to phil-flex/synapse
that referenced
this pull request
Jun 16, 2020
…atrix-org#7502) In a new room version, the "notifications" key of power level events are subject to restricted auth rules.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7501
This adds a new flag to
RoomVersionto specify when to enforce the additional rules on power level events, it then implements the logic to enforce this. Includes a basic test.