This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add type hints to event_auth code. #7505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
commented
May 14, 2020
Comment on lines
+215
to
+217
| # There should always be a creation event, but if not don't federate. | ||
| if not creation_event: | ||
| return False |
There was a problem hiding this comment.
This was necessary to make mypy happy, it shouldn't happen but seems like a good guard.
clokep
commented
May 14, 2020
| key = (EventTypes.Member, event.user_id) | ||
| member_event = auth_events.get(key) | ||
|
|
||
| return _check_joined_room(member_event, event.user_id, event.room_id) | ||
| _check_joined_room(member_event, event.user_id, event.room_id) |
There was a problem hiding this comment.
The return on this line was useless since _check_joined_room doesn't return anything.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #7502 I quickly added some types to the
synapse.event_authmodule.