Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

synapse_port_db error handling is broken. #7655

Closed
erikjohnston opened this issue Jun 8, 2020 · 1 comment
Closed

synapse_port_db error handling is broken. #7655

erikjohnston opened this issue Jun 8, 2020 · 1 comment
Labels
z-bug (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)

Comments

@erikjohnston
Copy link
Member

When there is an error, e.g. like in #7654, we fail to handle it properly and bail with a separate error:

Traceback (most recent call last):
  File "/root/synapse/env/bin/synapse_port_db", line 1056, in <module>
    sys.stderr.write(end_error)
TypeError: write() argument must be str, not FirstError
@erikjohnston erikjohnston added z-bug (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label) labels Jun 8, 2020
@richvdh
Copy link
Member

richvdh commented Nov 12, 2020

fixed by #8585 I think

@richvdh richvdh closed this as completed Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-bug (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

2 participants