Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Require parameterized package version to be at least 0.7.0. #7680

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

OlegGirko
Copy link
Contributor

Older versions of parameterized package have no parameterized_class decorator.
This decorator is used in tests.

@OlegGirko OlegGirko changed the title Require parameterized package version to be at least 0.7.0. Require parameterized package version to be at least 0.7.0. Jun 11, 2020
@OlegGirko OlegGirko force-pushed the fix_parameterized_dep branch from 8073cb2 to e2cdf6b Compare June 11, 2020 20:37
@richvdh richvdh requested a review from a team June 12, 2020 08:43
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog.d/7680.bugfix Outdated Show resolved Hide resolved
Older versions have no parameterized_class decorator.

Signed-off-by: Oleg Girko <ol@infoserver.lv>
@OlegGirko OlegGirko force-pushed the fix_parameterized_dep branch from 3952637 to 17d1bfd Compare June 12, 2020 12:35
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all concerns have been addressed. Thanks!

@anoadragon453 anoadragon453 merged commit 96bc110 into matrix-org:develop Jun 17, 2020
@OlegGirko OlegGirko deleted the fix_parameterized_dep branch June 17, 2020 14:35
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '96bc110a6':
  Require parameterized package version to be at least 0.7.0. (#7680)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants