This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add support for sharding the client reader. #7830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
clokep/client-reader-tests
branch
from
daa2c27 to
bae66a7
Compare
clokep
force-pushed
the
clokep/client-reader-tests
branch
from
bae66a7 to
c11f7ee
Compare
Co-authored-by: Erik Johnston <erik@matrix.org>
clokep
commented
Jul 13, 2020
| @@ -40,7 +40,8 @@ def __init__(self, hs): | |||
|
|
|||
| # Start the user parter loop so it can resume parting users from rooms where | |||
| # it left off (if it has work left to do). | |||
| hs.get_reactor().callWhenRunning(self._start_user_parting) | |||
| if hs.config.worker_app is None: | |||
| hs.get_reactor().callWhenRunning(self._start_user_parting) | |||
There was a problem hiding this comment.
I think it is worth pointing out also that we don't seem to use this pattern of callWhenRunning anywhere else for background processes. I wonder if that method can just go away and we can directly call the code from it?
Not really related to this PR, just found it odd.
There was a problem hiding this comment.
I think we tend to do loopings calls, which also won't run until we're started? I think it makes sense to only start work once we've finished starting up
|
@erikjohnston Not sure if you meant to approve this or not. 😄 |
erikjohnston
approved these changes
Jul 13, 2020
|
Oh, I was waiting on words in |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '457096e6d': Support handling registration requests across multiple client readers. (#7830)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly just tests, but does make one change to ensure that a background process only runs on a single process. I'm not 100% sure this is necessary, but I think it is.
Fixes #7672