This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix guest user registration with lots of client readers #7866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partly just to show it works, but alwo to remove a bit of code duplication.
richvdh
force-pushed
the
rav/fix_guest_user_id
branch
2 times, most recently
from
eb0590d to
9648f0f
Compare
|
the commits here should stand alone and be easier to review. |
richvdh
force-pushed
the
rav/fix_guest_user_id
branch
from
9648f0f to
16368c8
Compare
erikjohnston
approved these changes
Jul 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to use a Postgres sequence to generate guest user IDs. First do some refactoring to make the existing stuff that is backed by sequences reusable.