Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Allow docker to take multiple configuration files (e.g. for worker mode) #8065

Closed
JuniorJPDJ opened this issue Aug 12, 2020 · 6 comments
Closed
Labels
A-Docker Docker images, or making it easier to run Synapse in a container. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)

Comments

@JuniorJPDJ
Copy link

If I understood docs correctly - this feature is already working outside of docker and worker docs are written like it were available in every supported scenario - also in docker.
I managed to run workers in docker (after few days of fight with docs not being docker-ready - #8053).
Now I'm concatenating configs outside of docker, which is far from ideal solution, I need to remember to refresh configs after change in homeserver.yaml and in worker config itself.

@clokep
Copy link
Member

clokep commented Aug 12, 2020

I suspect what would be nice is if you can give the docker container multiple configuration files, which is what the worker docs assume is possible?

@clokep clokep changed the title Automatic concatenation of worker config with homeserver one for docker Allow docker to take multiple configuration files (e.g. for worker mode) Aug 12, 2020
@clokep clokep added A-Docker Docker images, or making it easier to run Synapse in a container. z-p3 (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution labels Aug 12, 2020
@JuniorJPDJ
Copy link
Author

It's better approach of what I was thinking about, thank you for specification :)

@ptman
Copy link
Contributor

ptman commented Aug 13, 2020

Would that help help with #6662 as well?

@JuniorJPDJ
Copy link
Author

@ptman It could ;D

@richvdh
Copy link
Member

richvdh commented Aug 13, 2020

It sounds like this might just be a duplicate of #6662?

@clokep
Copy link
Member

clokep commented Aug 13, 2020

Sounds like a duplicate, yep!

@clokep clokep closed this as completed Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Docker Docker images, or making it easier to run Synapse in a container. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

4 participants