Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Synapse allows empty localpart in a room ID over federation #8126

Closed
jplatte opened this issue Aug 19, 2020 · 6 comments
Closed

Synapse allows empty localpart in a room ID over federation #8126

jplatte opened this issue Aug 19, 2020 · 6 comments

Comments

@jplatte
Copy link
Contributor

jplatte commented Aug 19, 2020

Description

!:sorunome.de is an existing room (made as an experiment using a patched Synapse). MSC 1597 specifies

The opaque_id part must not be empty, and must consist entirely of the characters [0-9a-zA-Z.=_-].

Version information

  • Homeserver: matrix.org
@richvdh
Copy link
Member

richvdh commented Aug 19, 2020

I daresay it allows all sorts of malformed room IDs, and indeed events as a whole.

related: https://github.com/matrix-org/matrix-doc/issues/1646.

@richvdh
Copy link
Member

richvdh commented Aug 19, 2020

actually, on closer inspection, this isn't yet in the spec. MSC1597 is not (yet) implemented, and probably never will be.

@richvdh richvdh closed this as completed Aug 19, 2020
@jplatte
Copy link
Contributor Author

jplatte commented Aug 19, 2020

and probably never will be

What? What significance does a merged MSC have, then??

@richvdh
Copy link
Member

richvdh commented Aug 19, 2020

@jplatte I refer you to the answer given last time you asked that question: matrix-org/matrix-spec-proposals#1598 (comment).

@jplatte
Copy link
Contributor Author

jplatte commented Aug 19, 2020

I don't get it, so stuff should land in the spec first and then in Synapse? What about all the things Synapse does first that later land in the spec?

@richvdh
Copy link
Member

richvdh commented Aug 19, 2020

[this conversation moved elsewhere]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants