Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Email matching for invitations is case-sensitive #8522

Closed
abliss opened this issue Oct 12, 2020 · 6 comments
Closed

Email matching for invitations is case-sensitive #8522

abliss opened this issue Oct 12, 2020 · 6 comments
Labels
A-Invite Inviting users to rooms and accepting invites T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-bug (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)

Comments

@abliss
Copy link

abliss commented Oct 12, 2020

Description

When inviting someone to a channel by email, the email is matched case-sensitively. It should be case insensitive.

Steps to reproduce

  • Create a private channel
  • Invite with email a new user who has never used matrix. Use a capital letter in the email address, like User@example.com
  • The new user receives the email and tries to log in, but uses an all-lowerecase email, like user@example.com

Expected: User should be able to log in.
Actual : User is denied with a message like: "This invite to this room was sent to User@example.com which is not associated with your account"

Version information

  • Homeserver: matrix.org (using the riot.im frontend)
@dklimpel
Copy link
Contributor

It is related to #7021 and #7016

@anoadragon453 anoadragon453 added z-bug (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label) labels Oct 12, 2020
@MadLittleMods MadLittleMods added A-Invite Inviting users to rooms and accepting invites T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels May 16, 2022
@Vetchu
Copy link
Contributor

Vetchu commented Jun 10, 2022

I think this issue is already fixed, as I cannot reproduce it: I invited my other email starting with capital letter, during process of registration I used all lowercase and it worked like a charm.

@Vetchu
Copy link
Contributor

Vetchu commented Jun 15, 2022

@MadLittleMods care to take a look and close this issue if this is no longer a problem? I'd submit a fix, but I cannot reproduce it on matrix.org

@DMRobertson
Copy link
Contributor

I invited my other email starting with capital letter, during process of registration I used all lowercase and it worked like a charm.

To clarify:

  • were you able to register a new account using the all-lowercase address?
  • when logged in to that new account, did the client show the invite you made before?

@Vetchu
Copy link
Contributor

Vetchu commented Jun 15, 2022

Yes, I followed this procedure:

I think this reproduces the thinking presented in OP, and it does not produce an error anymore. I can reproduce with screenshots if needed.

@DMRobertson
Copy link
Contributor

That's fine, I was just checking what "worked like a charm".

Given that there have been fixes in the area let's close this. Can reopen if it turns out we missed something.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Invite Inviting users to rooms and accepting invites T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-bug (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

6 participants