Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

KeyError in synapse.push.mailer in get_message_vars #9256

Closed
clokep opened this issue Jan 28, 2021 · 0 comments · Fixed by #9257
Closed

KeyError in synapse.push.mailer in get_message_vars #9256

clokep opened this issue Jan 28, 2021 · 0 comments · Fixed by #9257
Assignees
@clokep
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@clokep
Copy link
Member

clokep commented Jan 28, 2021

See https://sentry.matrix.org/sentry/synapse-matrixorg/issues/190798/

It looks like this is happening when a user is no longer in the room when prepping to send an email notification (this is likely due to the user leaving during the delay between an event being received and sending the email).

For some situations we should likely just ignore the notification and move on, but in some situations we probably want to notify the user that they've been kicked / banned / whatever.
@clokep clokep added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jan 28, 2021
@clokep clokep self-assigned this Jan 28, 2021
@clokep clokep linked a pull request Jan 28, 2021 that will close this issue
Handle empty rooms when generating email notifications. #9257
Merged
@clokep clokep mentioned this issue Jan 28, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle empty rooms when generating email notifications. matrix-org/synapse
1 participant
@clokep