Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Consider to include a Dockerfile #969

Closed
silvio opened this issue Jul 30, 2016 · 8 comments
Closed

Consider to include a Dockerfile #969

silvio opened this issue Jul 30, 2016 · 8 comments

Comments

@silvio
Copy link

silvio commented Jul 30, 2016

Currently I maintain http://github.com/silvio/docker-matrix. I think it would be a great idea to include this approach to the official synapse sources.

The surplus would be that every release of matrix gets an official docker release. Bug fixes and Security fixes could be released very early.

The user can pull a specific releases via docker pull matrix-org/docker-matrix:v3.4 or the latest version via docker pull matrix-org/docker-matrix:latest.

The current docker file needs changes for this.

@almereyda
Copy link
Contributor

almereyda commented Sep 28, 2016

I can only support a vote for official Docker images of the Matrix ecosystem, especially since services can be quickly spun up with that infrastructure.

Yet as the Docker ecosystem is moving fast and breaking often, the recent moves on compose and swarm ask for catching up and splitting a server into a combination of individual services. The links in #378 show an approach which forked of the excellent preliminary work of @silvio:

I was using a two step set up procedure involving docker-compose -f generate.yml up (generate.yml) as a one off command preparing the configs, and only then starting the deamons via docker-compose up -d. Unfortunately this is not yet documented in the docker-matrix README.

The source repositories for the individual images live at:

I was always thinking I had something to hide, why they are not on GitHub (yet) as the configurations used include already public facts of the actual allmende.io deployment and are not generalised.

I am especially not fond of https://lab.allmende.io/allmende/docker-vector/blob/master/Dockerfile#L72-73, but believe the new ARG keyword may come in handy here.

Please have a look, fork off and see if we can build something together out of our different branches.

@fuzzy76
Copy link

fuzzy76 commented May 8, 2017

Any more thoughts on this? FWIW, docker best practices revolve around 1 process per container, so I agree that one service per container makes more sense. It also allows me to choose myself which services I want.

@ara4n
Copy link
Member

ara4n commented May 8, 2017

I absolutely agree that we need an official Dockerfile. @superdump perhaps you can add this at medium-prio to your hit list?

@almereyda
Copy link
Contributor

almereyda commented May 8, 2017

@fuzzy76
Copy link

fuzzy76 commented May 9, 2017

...which is the problem. I have no idea which to pick, and don't want to get stuck with something that's abandoned when synapse get an official setup.

@ptman
Copy link
Contributor

ptman commented Oct 21, 2017

#2482

@ptman
Copy link
Contributor

ptman commented Jan 5, 2018

@fuzzy76 It should be quite easy to move from dropped image to official, when that day comes. Data lives in database (and media_store/). Config needs to be rescued.

@richvdh
Copy link
Member

richvdh commented May 15, 2018

now finally fixed by #2846

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants