-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactoring]: fix cases marked by linter errcheck
for package github.com/matrixorigin/matrixone/pkg/vm/engine
#2523
Comments
Related issue #2133 |
cnutshell
changed the title
[Refactoring]: fix cases marked by linter
[Refactoring]: fix cases marked by linter May 13, 2022
errcheck
for package github.com/matrixorigin/matrixone/pkg/vm/engine/tae
errcheck
for package github.com/matrixorigin/matrixone/pkg/vm/engine
|
7 tasks
TPE errcheck @daviszhen
|
For commit golangci-lint run --disable-all -E errcheck \
--max-same-issues 10000 --max-issues-per-linter 10000 \
--skip-files ".+_test.go" pkg/vm/engine/... | wc -l
186 |
Since the code is refactored, new issue #3853 will track the lint error. |
JinHai-CN
assigned sukki37 and unassigned LeftHandCold, XuPeng-SH, jiangxinmeng1 and daviszhen
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for the refactoring request?
Is your refactoring request related to a problem?
Describe the solution you'd like
Check all the cases marked by linter
errcheck
and evaluate them.If an unchecked error can be critical bugs in some cases, then fix it.
Describe alternatives you've considered
No response
Additional information
How to find all the cases via
errcheck
for packagegithub.com/matrixorigin/matrixone/pkg/vm/engine
:If you want to find cases for non-test code only, using option
--skip-files ".+_test.go"
:golangci-lint run --disable-all -E errcheck \ --max-same-issues 10000 --max-issues-per-linter 10000 --skip-files ".+_test.go" pkg/vm/engine/...
The output of this command would be:
The text was updated successfully, but these errors were encountered: