Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is broken when trying to use Bytes feature #90

Closed
jwilm opened this issue Sep 18, 2023 · 2 comments
Closed

Build is broken when trying to use Bytes feature #90

jwilm opened this issue Sep 18, 2023 · 2 comments

Comments

@jwilm
Copy link

jwilm commented Sep 18, 2023

Hi, we are trying to use Magnus with the Bytes feature, and it appears 0.6.1 is broken on crates.io

jwilm@cartella  ~/code/magnus  cargo build --features bytes
  Downloaded bytes v1.4.0
  Downloaded 1 crate (58.1 KB) in 0.16s
   Compiling bytes v1.4.0
   Compiling magnus v0.6.1 (/home/jwilm/code/magnus)
error[E0277]: the trait bound `value::Value: From<r_string::RString>` is not satisfied
    --> src/r_string.rs:1747:46
     |
1747 |         handle.str_from_slice(self.as_ref()).into()
     |                                              ^^^^ the trait `From<r_string::RString>` is not implemented for `value::Value`
     |
     = note: required for `r_string::RString` to implement `Into<value::Value>`

jwilm@cartella  ~/code/magnus  rustc -V
rustc 1.72.0 (5680fa18f 2023-08-23)
@matsadler
Copy link
Owner

Sorry about that. Turns out the tests for the bytes feature weren't being run, so I missed something when making changes elsewhere.

Tests should be running now, and I've put out a 0.6.2 release that fixes the error.

Thank you for the bug report.

@jwilm
Copy link
Author

jwilm commented Sep 19, 2023

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants