Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the 'web' OAuth2 app type #213

Closed
3 tasks done
mattbdean opened this issue Jan 10, 2018 · 2 comments
Closed
3 tasks done

Support the 'web' OAuth2 app type #213

mattbdean opened this issue Jan 10, 2018 · 2 comments
Labels
enhancement
Milestone
v1.1.0

Comments

@mattbdean
Copy link
Owner

mattbdean commented Jan 10, 2018 •
edited
Loading

Right now OAuthHelper.interactive throws a NotImplementedError when given webapp Credentials. Shouldn't be too hard to get this working. It'll require us to have more data in credentials.json

  • Add appropriate code to OAuthHelper.interactive and expand OAuthHelper tests
  • Update the readme, specifically the section about the shape of credentials.json
  • Update :meta:credentials to generate an OAuth2 app of type web
@mattbdean mattbdean added this to the v1.1.0 milestone Jan 10, 2018
@mattbdean mattbdean mentioned this issue May 19, 2018
Closed
@koflin
Copy link

koflin commented May 30, 2018

Is this now implemented in v1.1.0 ?

@mattbdean
Copy link
Owner Author

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@mattbdean @koflin