Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't load all comments #56

Closed
gjmills opened this issue Mar 18, 2015 · 2 comments
Closed

Doesn't load all comments #56

gjmills opened this issue Mar 18, 2015 · 2 comments
Labels

Comments

@gjmills
Copy link

gjmills commented Mar 18, 2015

Some comment trees have a "continue this thread" option. Currently JRAW doesn't expand the full comment tree:

see e.g.

http://www.reddit.com/r/test/comments/2onit4/test_depth_0/

(scroll down to depth 10)

This is a known issue and has recently been fixed on PRAW, see e.g.

http://www.reddit.com/r/redditdev/comments/2onkd8/praw_maximum_depth_of_subtrees/

@mattbdean
Copy link
Owner

Ok thanks I'll take a look at it. The solution PRAW used should be simple enough to implement.

@mattbdean
Copy link
Owner

Commits fc968c5 and cf384d1 address this issue.

To see it in action, see this example:

RedditClient reddit = // <whatever>
CommentNode root = reddit.getSubmission("2onit4").getComments();
root.loadFully(reddit); // Expand all MoreChildren objects
root.visualize(); // Preview the thread using the Logger

This results in this output:

[main] INFO JRAW - (1↑) hooked_dev: test - depth 1
[main] INFO JRAW -   (1↑) hooked_dev: test - depth 2
[main] INFO JRAW -     (1↑) hooked_dev: test - depth 3
[main] INFO JRAW -       (1↑) hooked_dev: test - depth 4
[main] INFO JRAW -         (1↑) hooked_dev: test - depth 5
[main] INFO JRAW -           (1↑) hooked_dev: test - depth 6
[main] INFO JRAW -             (1↑) hooked_dev: test - depth 7
[main] INFO JRAW -               (1↑) hooked_dev: test - depth 8
[main] INFO JRAW -                 (1↑) hooked_dev: test - depth 9
[main] INFO JRAW -                   (1↑) hooked_dev: test - depth 10
[main] INFO JRAW -                     (1↑) hooked_dev: test - depth 11
[main] INFO JRAW -                       (1↑) hooked_dev: test - depth 12
[main] INFO JRAW -                         (1↑) hooked_dev: test - depth 13
[main] INFO JRAW -                           (1↑) hooked_dev: test - depth 14
[main] INFO JRAW -                             (1↑) hooked_dev: test - depth 15
[main] INFO JRAW -             (1↑) hooked_dev: Alternate - depth 7
[main] INFO JRAW -               (1↑) hooked_dev: Alternate - depth 8
[main] INFO JRAW -                 (1↑) hooked_dev: Alternate - depth 9
[main] INFO JRAW -                   (1↑) hooked_dev: Alternate - depth 10
[main] INFO JRAW -                     (1↑) hooked_dev: Alternate - depth 11
[main] INFO JRAW -                       (1↑) hooked_dev: Alternate - depth 12
[main] INFO JRAW -                         (1↑) hooked_dev: Alternate - depth 13
[main] INFO JRAW -                           (1↑) hooked_dev: Alternate - depth 14
[main] INFO JRAW -                             (1↑) hooked_dev: Alternate - depth 15
[main] INFO JRAW -                               (1↑) hooked_dev: Alternate - depth 16
[main] INFO JRAW -                                 (1↑) hooked_dev: Alternate - depth 17
[main] INFO JRAW -                                   (1↑) hooked_dev: Alternate - depth 18
[main] INFO JRAW -                                     (1↑) hooked_dev: Alternate - depth 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants