Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About typescript type definition #537

Comments

@Alfred-Skyblue
Copy link

Alfred-Skyblue commented Mar 17, 2023

Description

I found that the type definition for TypedOptions was removed in the latest commit, but I need to use it and I wonder why it was removed.

@mattboldt
Copy link
Owner

Sorry about that, I'm not sure how that got deleted. Should be fixed with the latest release!

@omermecitoglu
Copy link

Could not find a declaration file for module 'typed.js'. '.../node_modules/typed.js/dist/typed.module.js' implicitly has an 'any' type.

There are types at '.../node_modules/typed.js/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'typed.js' library may need to update its package.json or typings.ts(7016)

@TaylorFacen
Copy link

Hi, I'm running into the issue above as well.

@mattboldt
Copy link
Owner

reopening to investigate this one.

@TaylorFacen
Copy link

@mattboldt i believe this PR fixes the problem: #589

@mattboldt
Copy link
Owner

@TaylorFacen thank you, just merged. Could you install the package from main and confirm it's working? Then I'll push a new version tag & release to npm

@TaylorFacen
Copy link

CleanShot 2023-10-16 at 10 42 37@2x

It works! The error message is gone and the Typed object has the right typescript type.

@simbo
Copy link

simbo commented Nov 7, 2023

@mattboldt Anything still missing for releasing this to npm? 😬

@mattboldt
Copy link
Owner

Nope, I just need to push a release. Sorry, haven't had a moment to work on this.

@mattboldt
Copy link
Owner

fixed in latest version v2.1.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment