-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security issue: prevent BadAlloc #22
Comments
I just realized, adjust_request_size() can return already |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
see: https://msrc-blog.microsoft.com/2021/04/29/badalloc-memory-allocation-vulnerabilities-could-affect-wide-range-of-iot-and-ot-devices-in-industrial-medical-and-enterprise-networks/
in case
tlsf_alloc
is called with0xffffffffu
on a 32bit system thealign_up()
function will set theadjusted
size to 0 and thetlfs_max()
will set it to the minimum which was in my case 12 bytes. Therefore asking TLSF for SIZE_T_MAX (0xffffffff) will not fail with returning NULL but will return a pointer to a 12 byte memory block.tlsf_alloc is kind of easy to fix, but the
_realloc
brother is less obvious. So fixing it inadjust_request_size()
isn't really working.The text was updated successfully, but these errors were encountered: