Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen should support widescreen HD displays. #4

Open
harp37 opened this issue Nov 25, 2014 · 3 comments
Open

Fullscreen should support widescreen HD displays. #4

harp37 opened this issue Nov 25, 2014 · 3 comments

Comments

@harp37
Copy link

harp37 commented Nov 25, 2014

Even 720p would be great.

@vwbusguy
Copy link

It's hard coded in https://github.com/mattdm/icebreaker/blob/release/icebreaker.h#L147. I'm not sure how much the aspect ratio matters, but it's possibly to fetch available display modes. The difficulty is that windows and Linux have different display servers, and Linux two (which can still be determined through $XDG_SESSION_TYPE.). One thing you might try is overriding those two definitions with a 720p 16:9 aspect ratio (or the closest your monitor supports), compiling it, and seeing if it displays correctly. If so, then it should be a matter of being able to read what the display supports and giving the user and option to override those values.

@vwbusguy
Copy link

It may actually be easier than I thought. Since it's using sdl2, it may be possible to simply use sdl2 to read the current display resolution was a basis for full screen resolution. That should be tested on HIDPI displays, though.

Ref. https://wiki.libsdl.org/SDL_GetDesktopDisplayMode

@mattdm
Copy link
Owner

mattdm commented Dec 23, 2020

It is using SDL 1, alas. SDL 2 wasn't released for another decade. Porting it to SDL 2 should probably be task number 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants