Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System properties aren't actually checked for changes in reload logic #278

Open
Woodham opened this issue Feb 12, 2021 · 0 comments
Open

Comments

@Woodham
Copy link

Woodham commented Feb 12, 2021

Looking at this line: https://github.com/lviggiano/owner/blob/0f0bfac11139264c27820bbc9c030c7448d395b9/owner/src/main/java/org/aeonbits/owner/HotReloadLogic.java#L69

It looks like the intention was to check if the hash of all system properties had changed since the last check, but newHash is not actually updated and just uses the original cached version of the system properties.

I suspect it's missing props = system().getProperties(); above that line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant