-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to provide a client side certificate #35
Comments
Hi @seesharper not at the moment. We use |
I see that requests already supports this: https://github.com/request/request#tlsssl-protocol |
Thanks a lot for your quick response and for a really great tool. Love it. Let't hope that the PR gets merged so that client side certificates can be supported. That would really be super useful :) |
Maybe it could be possible to create an abstraction somehow that lets you pick any http client library you want. Somewhere in the lines of just specifying a function that represents the actual HTTP call where that function just redirects to your http client library of choice |
That may be a good idea but realistically complicated to do. Mostly because each module has its own interface and I would just prefer to have the best available in the community rather than add a lot of complexity for a minimal gain. TBH, when we worked on the first iterations a couple of years ago, superagent and request were equally popular and featured. Nowadays, it looks to me that request has more features and seems to be more maintained and used. So, at this point, I would be more in favour of just switching to request. I'll open a separate issue for that. |
Hi!
Is there somehow I can provide a client side certificate when hitting an https endpoint?
The text was updated successfully, but these errors were encountered: