New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid branch name #96

Open

knobik opened this issue Mar 9, 2016 · 1 comment

Labels

Awaiting Feedback

knobik commented Mar 9, 2016

When im using

$branches = $repository->getBranches(false, true);

im getting this error

the branch string is not valid: remotes/origin/HEAD -> origin/master
/vendor/cypresslab/gitelephant/src/GitElephant/Objects/Branch.php:199

    public static function getMatches($branchString)
    {
        $matches = array();
        preg_match('/^\*?\ *?(\S+)\ +(\S{40})\ +(.+)$/', trim($branchString), $matches);
        if (!count($matches)) {
            throw new \InvalidArgumentException(sprintf('the branch string is not valid: %s', $branchString));
        }

The text was updated successfully, but these errors were encountered:

Collaborator

GenieTim commented Jan 4, 2019

The corresponding code has been altered in the meantime. Is this error still reproducible?

GenieTim added the Awaiting Feedback label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment