Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query unpacking is slow #30

Closed
Ukendio opened this issue Jan 29, 2024 · 1 comment · Fixed by #27
Closed

Query unpacking is slow #30

Ukendio opened this issue Jan 29, 2024 · 1 comment · Fixed by #27
Labels
improvement An imperfection we can make better

Comments

@Ukendio
Copy link
Member

Ukendio commented Jan 29, 2024

From #28

The unpacking of the columns is very expensive and is a large part of the queries overhead. This is in general a problem with a lack of good iterators in luau, and unless theres tuples or array destructering introduced the only reasonable solution we can do at the user-space level is to enable optimizations for hotpaths by inlining indexes into the columns.

@Ukendio Ukendio added the improvement An imperfection we can make better label Jan 29, 2024
@Ukendio
Copy link
Member Author

Ukendio commented Jan 29, 2024

Resolved at #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An imperfection we can make better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant