Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alamofire lib and rewrite network services #10

Open
TonioMacaronio opened this issue Sep 29, 2018 · 2 comments
Open

Add alamofire lib and rewrite network services #10

TonioMacaronio opened this issue Sep 29, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest

Comments

@TonioMacaronio
Copy link
Contributor

TonioMacaronio commented Sep 29, 2018

Current behavior:
Now it is native URLSession used to load some data and interact with APIs.

Expected behavior:
Add Alamofire lib and rewrite URLSessions with Alamofire.

Suggested solution:
You can add Alamofire lib via CocoaPods.
All networking should be the separate class, that has functions with required parameters and do all the work by Alamofire.

Acceptance Criteria:
The code is written in new branch named feature/Alamofire or something like that.
The code implements the targets described above.
The code can be merged into the develop branch without conflicts.

Required Skill:
Participants needs to have a bit of experience in Swift software development.

@RommelTJ
Copy link
Contributor

Started work on this via #25.

@RommelTJ
Copy link
Contributor

PR #25 is merged, so I'll open a new PR in the future for the remaining work. Thanks @BaldyAsh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants