Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add image or video to peep #11

Open
TonioMacaronio opened this issue Sep 29, 2018 · 3 comments
Open

Feature: add image or video to peep #11

TonioMacaronio opened this issue Sep 29, 2018 · 3 comments
Labels
enhancement New feature or request Hacktoberfest

Comments

@TonioMacaronio
Copy link
Contributor

TonioMacaronio commented Sep 29, 2018

Current behavior:
Now you can only send Peep with some text data in it.

Expected behavior:
Need to send Peep with image or video data in it both to PeepEth server and to blockchain.

Solution:
It’s needed to prepare sending data to server and Ethereum blockchain.
Carefully look at how Peeps are sending now.
Sending controller is SendPeepViewController.
After tapping "Send" button and writing correct password will be formed Server Peep:

let peep = Peep(type: "peep",
                content: content,
                pic: "",
                untrustedAddress: address!,
                untrustedTimestamp: Int(Date().timeIntervalSince1970),
                shareID: shareHash,
                parentID: parentHash)

let createdServerPeep = CreateServerPeep(ipfs: "xxx",
                                         author: address!,
                                         content: content,
                                         parentID: parentHash,
                                         shareID: shareHash,
                                         twitterShare: false,
                                         picIpfs: "", // LOOK, its empty now. But it most likely shouldn't be
                                         origContents: peep,
                                         shareNow: true)

Then peep is posting to Peepeth server. In response you will get peeps hash from IPFS. In case of success you can optionally post peep to blockchain. But most likely you will not need to change anything further, since only a hash of a peep is required to send a transaction.

Perhaps you need just to load image to some server and use its link when forming Peeps data. To get more info send Peep from Desktop PeepEth in Chrome using Developer Tools to “reverse engineer it”.

Acceptance Criteria:
The code is written in new branch named feature/sendMedia or something like that.
The code implements the targets described above.
The code can be merged into the develop branch without conflicts.

Required Skill:
Participants needs to have experience in Swift software development.

@TonioMacaronio TonioMacaronio added enhancement New feature or request Hacktoberfest labels Sep 29, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.

@ShivaHuang
Copy link

After looking at current code, there is no IPFS endpoint now, right?

Will you provide one or we need to setup one ourself?

@gitcoinbot
Copy link

gitcoinbot commented Jan 21, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 3 years, 3 months ago.
Please review their action plans below:

1) shivahuang has applied to start work (Funders only: approve worker | reject worker).

After looking at current code, there is no IPFS endpoint now, right?

Will you provide one or we need to setup one ourself?
2) adivyas99 has applied to start work (Funders only: approve worker | reject worker).

I have a good experience with Swift, and planning to solve the issue within 3 days.
3) luccifer has applied to start work (Funders only: approve worker | reject worker).

Hey! Easy to implement, call at will if you need it fast and safe
4) xboehmx33 has applied to start work (Funders only: approve worker | reject worker).

Add image or video to peep in compliance with the request

Learn more on the Gitcoin Issue Details page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants