Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename current_miniblock #131

Closed
mm-zk opened this issue Sep 22, 2023 · 0 comments · Fixed by #135
Closed

Rename current_miniblock #131

mm-zk opened this issue Sep 22, 2023 · 0 comments · Fixed by #135
Labels
feature ➕ Feature item medium 🚩 Indicates moderately difficult item p2 🟡 Indicates moderately high priority item

Comments

@mm-zk
Copy link
Collaborator

mm-zk commented Sep 22, 2023

🌟 Feature Request

📝 Description

We have 3 similar sounding fields (current_batch, current_timestamp, current_miniblock) - but they have different behavior - the next transaction will be in 'current_batch' BATCH, with current_timestamp timestamp, but with current_miniblock+1 block.

🤔 Rationale

To make it less confusing for people who read the code.
@MexicanAce MexicanAce added p2 🟡 Indicates moderately high priority item starter 🏁 Indicates low difficulty item feature ➕ Feature item medium 🚩 Indicates moderately difficult item and removed starter 🏁 Indicates low difficulty item labels Sep 22, 2023
@nbaztec nbaztec mentioned this issue Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature ➕ Feature item medium 🚩 Indicates moderately difficult item p2 🟡 Indicates moderately high priority item
Projects
None yet
Milestone
No milestone
2 participants
@MexicanAce @mm-zk