feat(cli)!: replay transactions when forking at a tx hash #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
previously approved these changes
Jan 23, 2025
There was a problem hiding this comment.
I'd still wait for @dutterbutter to agree with this approach (just in case).
itegulov
changed the title
|
Had to update the semantic PR title action as the old one is deprecated and was mad at my title for some reason... |
dutterbutter
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
This PR changes behaviour of
anvil-zksync fork --fork-url <url> --fork-transaction-hash <hash>:Before: fork is initialized at the parent of the block containing provided tx hash, earlier transactions are not replayed
Now: fork is initialized at the parent of the block containing provided tx hash, earlier transactions are replayed
Why ✋
This better aligns to what I would expect to happen but admittedly this is a breaking change