Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent Finalization Failure #193

Closed
bxpana opened this issue Oct 8, 2024 · 3 comments
Closed

Intermittent Finalization Failure #193

bxpana opened this issue Oct 8, 2024 · 3 comments
Assignees

Comments

@bxpana
Copy link

bxpana commented Oct 8, 2024

As shown in zkSync-Community-Hub/zksync-developers#719, zkSync-Community-Hub/zksync-developers#711, and zkSync-Community-Hub/zksync-developers#636 there are intermittent issues where finalizing and claiming withdrawals from https://portal.zksync.io/ does not work as expected and results in the error message:

Error Message:
Fee estimation error: The contract function "finalizeWithdrawal" reverted with the following reason:
xx

@popzxc
Copy link
Member

popzxc commented Oct 9, 2024

Error originates from _proveL2LogInclusion function:

    /// @dev Prove that a specific L2 log was sent in a specific L2 batch number
    function _proveL2LogInclusion(
        uint256 _batchNumber,
        uint256 _index,
        L2Log memory _log,
        bytes32[] calldata _proof
    ) internal view returns (bool) {
        require(_batchNumber <= s.totalBatchesExecuted, "xx");
      // ...

I guess the contract is invoked with invalid parameters (at the very least -- batch number) under some circumstances.

@popzxc
Copy link
Member

popzxc commented Oct 9, 2024

I also see that we have something like this to report that withdrawal is already finalized, but:

  1. According to the reports, I guess it's not true?
  2. Looking at reported error messages, looks like now there is a newline in the error, so this handler probably doesn't work.

@popzxc
Copy link
Member

popzxc commented Nov 15, 2024

Hopefully, this has been fixed by #197. If not, let's reopen.

@popzxc popzxc closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants