feat: add dapp-portal support to zk_inception #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
reviewed
Aug 15, 2024
Deniallugo
reviewed
Aug 16, 2024
Deniallugo
reviewed
Aug 19, 2024
Deniallugo
reviewed
Aug 20, 2024
Deniallugo
approved these changes
Aug 20, 2024
Deniallugo
pushed a commit
that referenced
this pull request
Aug 20, 2024
## What❔ This PR introduces a new `portal` subcommand to the `zk_inception` CLI tool, enabling users to easily launch the [dapp-portal](https://github.com/matter-labs/dapp-portal) for their deployed chains. Usage: `zk_inception portal [--port 3030]` The ecosystem configurations are automatically converted to the [hyperchains](https://github.com/matter-labs/dapp-portal/tree/main/hyperchains#%EF%B8%8F-configure-manually) format, which is used to configure dapp-portal at runtime. Essentially, the following command is executed under the hood: `docker run -p PORT:3000 /path/to/portal.config.js:/usr/src/app/dist/config.js dapp-portal` ## Why ❔ Currently, running the dapp-portal requires users to manually pull the repository, install all dependencies, modify configurations, build the project, and then run it - a tedious and time-consuming process. This PR simplifies the process, allowing users to run the portal effortlessly with a single command. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What❔
This PR introduces a new
portalsubcommand to thezk_inceptionCLI tool, enabling users to easily launch the dapp-portal for their deployed chains.Usage:
zk_inception portal [--port 3030]The ecosystem configurations are automatically converted to the hyperchains format, which is used to configure dapp-portal at runtime. Essentially, the following command is executed under the hood:
docker run -p PORT:3000 /path/to/portal.config.js:/usr/src/app/dist/config.js dapp-portalWhy ❔
Currently, running the dapp-portal requires users to manually pull the repository, install all dependencies, modify configurations, build the project, and then run it - a tedious and time-consuming process. This PR simplifies the process, allowing users to run the portal effortlessly with a single command.
Checklist
zk fmtandzk lint.