-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zk_toolbox): Deploy ConsensusRegistry (BFT-504) #2713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
force-pushed
the
bft-504-deploy-cons-reg
branch
from
August 22, 2024 15:34
988caa6
to
418ea7e
Compare
aakoshh
force-pushed
the
bft-504-deploy-cons-reg
branch
from
August 22, 2024 16:17
f4b7c12
to
5f82aea
Compare
Deniallugo
reviewed
Aug 23, 2024
zk_toolbox/crates/config/src/forge_interface/deploy_l2_contracts/input.rs
Outdated
Show resolved
Hide resolved
4 tasks
Deniallugo
previously approved these changes
Aug 27, 2024
aakoshh
force-pushed
the
bft-504-deploy-cons-reg
branch
from
September 2, 2024 17:30
7d9cd7e
to
24d73bd
Compare
brunoffranca
approved these changes
Sep 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sep 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adds a
zk_inception chain deploy-consensus-registry
command.TODO:
contracts
submodule back tomain
once feat: Deploy ConsensusRegistry through L1 to L2 transaction (BFT-504) era-contracts#735 is mergedContract Owner
The agreement was that on testnet the
ConsensusRegistry
contract should be owned by the governor account, which is 0xD64e136566a9E04eb05B30184fF577F52682D182, while on mainnet it should be owned by the developer multisig account.The owner is set in DeployL2ContractsInput::consensus_registry_owner which has access to contract and wallet configuration and these are written to a config file just before deployment.
I added an optionaldeveloper_multisig
wallet toWalletConfig
, so the address can be added at the same place as thegovernor
address is; ifdeveloper_multisig
is missing thengovernor
is used. I suppose it could be made part of theContractsConfig
instead, but since this is a wallet with funds that developers can access, I thought it wouldn't be out of place inwallets.yaml
even if one doesn't have any of the corresponding private keys. Let me know if I should be using something else.Testing
Since the
zk_toolbox
is replacing thezk
commands, andzk init
doesn't deploy the consensus registry, we have to use the following commands to see that the contract is built, deployed and its address is written to the config file:After this we can check if we see the address in the generated config file:
Finally clean up:
Why ❔
So that we can deploy the L2 consensus registry contract using the
zk_toolbox
.Checklist
zk fmt
andzk lint
.