fix: restore instruction count functionality #3081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonazan
commented
Oct 11, 2024
koloz193
previously approved these changes
Oct 11, 2024
|
heap_read_write is still N/A, which seems wrong. |
Detected VM performance changes
Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it run out of gas at a different time. Or that it is behaving completely differently. |
koloz193
approved these changes
Oct 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
🤖 I have created a release *beep* *boop* --- ## [25.0.0](core-v24.29.0...core-v25.0.0) (2024-10-23) ### ⚠ BREAKING CHANGES * **contracts:** integrate protocol defense changes ([#2737](#2737)) ### Features * Add CoinMarketCap external API ([#2971](#2971)) ([c1cb30e](c1cb30e)) * **api:** Implement eth_maxPriorityFeePerGas ([#3135](#3135)) ([35e84cc](35e84cc)) * **api:** Make acceptable values cache lag configurable ([#3028](#3028)) ([6747529](6747529)) * **contracts:** integrate protocol defense changes ([#2737](#2737)) ([c60a348](c60a348)) * **external-node:** save protocol version before opening a batch ([#3136](#3136)) ([d6de4f4](d6de4f4)) * Prover e2e test ([#2975](#2975)) ([0edd796](0edd796)) * **prover:** Add min_provers and dry_run features. Improve metrics and test. ([#3129](#3129)) ([7c28964](7c28964)) * **tee_verifier:** speedup SQL query for new jobs ([#3133](#3133)) ([30ceee8](30ceee8)) * vm2 tracers can access storage ([#3114](#3114)) ([e466b52](e466b52)) * **vm:** Return compressed bytecodes from `push_transaction()` ([#3126](#3126)) ([37f209f](37f209f)) ### Bug Fixes * **call_tracer:** Flat call tracer fixes for blocks ([#3095](#3095)) ([30ddb29](30ddb29)) * **consensus:** preventing config update reverts ([#3148](#3148)) ([caee55f](caee55f)) * **en:** Return `SyncState` health check ([#3142](#3142)) ([abeee81](abeee81)) * **external-node:** delete empty unsealed batch on EN initialization ([#3125](#3125)) ([5d5214b](5d5214b)) * Fix counter metric type to be Counter. ([#3153](#3153)) ([08a3fe7](08a3fe7)) * **mempool:** minor mempool improvements ([#3113](#3113)) ([cd16083](cd16083)) * **prover:** Run for zero queue to allow scaling down to 0 ([#3115](#3115)) ([bbe1919](bbe1919)) * restore instruction count functionality ([#3081](#3081)) ([6159f75](6159f75)) * **state-keeper:** save call trace for upgrade txs ([#3132](#3132)) ([e1c363f](e1c363f)) * **tee_prover:** add zstd compression ([#3144](#3144)) ([7241ae1](7241ae1)) * **tee_verifier:** correctly initialize storage for re-execution ([#3017](#3017)) ([9d88373](9d88373)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back instruction counts that show that bytecode has changed rather than VM performance. They were previously disabled because vm2 didn't support tracers.