Skip to content

fix(zkstack): Fix wrong missing private key message #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

matias-gonz
Copy link
Member

What ❔

Add msg_wallet_private_key_not_set and return the correct wallet

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@matias-gonz matias-gonz changed the title fix(zkstack): Wrong missing private key message fix(zkstack): Fix wrong missing private key message Nov 26, 2024
@Deniallugo Deniallugo added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@Deniallugo Deniallugo added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@Deniallugo Deniallugo added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit aaca32b Nov 29, 2024
31 checks passed
@Deniallugo Deniallugo deleted the matias/fix-fill-forge-private-key-message branch November 29, 2024 09:46
zkzoomer pushed a commit that referenced this pull request Jun 21, 2025
## What ❔

Add msg_wallet_private_key_not_set and return the correct wallet

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants