Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): adds a get proof endpoint in zks namespace #455

Conversation

montekki
Copy link
Contributor

@montekki montekki commented Nov 9, 2023

What ❔

This PR adds a new JSON-RPC endpoint zks_getProof that allows users to request proofs
of data in the tree that can later be verified against storarage roots at a given point
in batch history.

@montekki montekki marked this pull request as ready for review November 10, 2023 15:37
@montekki montekki requested a review from a team as a code owner November 10, 2023 15:37
Copy link
Collaborator

@RomanBrodetski RomanBrodetski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits

core/lib/config/src/configs/api.rs Outdated Show resolved Hide resolved
core/lib/web3_decl/src/error.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/api_server/web3/namespaces/zks.rs Outdated Show resolved Hide resolved
@montekki montekki added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit f4313a4 Nov 14, 2023
21 checks passed
@montekki montekki deleted the fvs-pla-651-research-and-implement-eth_getproof-or-its-analog-for-era branch November 14, 2023 16:08
github-merge-queue bot pushed a commit that referenced this pull request Nov 15, 2023
🤖 I have created a release *beep* *boop*
---


##
[18.0.0](core-v17.1.0...core-v18.0.0)
(2023-11-14)


### ⚠ BREAKING CHANGES

* boojum integration
([#112](#112))

### Features

* **basic_witness_input_producer:** Witness inputs queued after BWIP run
([#345](#345))
([9c2be91](9c2be91))
* boojum integration
([#112](#112))
([e76d346](e76d346))
* **core:** adds a get proof endpoint in zks namespace
([#455](#455))
([f4313a4](f4313a4))
* **core:** Split config definitions and deserialization
([#414](#414))
([c7c6b32](c7c6b32))
* **dal:** Do not load config from env in DAL crate
([#444](#444))
([3fe1bb2](3fe1bb2))
* **house_keeper:** Remove GCS Blob Cleaner
([#321](#321))
([9548914](9548914))
* **job-processor:** report attempts metrics
([#448](#448))
([ab31f03](ab31f03))
* **vm:** Use the one interface for all vms
([#277](#277))
([91bb99b](91bb99b))


### Bug Fixes

* **boojnet:** various boojnet fixes
([#462](#462))
([f13648c](f13648c))
* change vks upgrade logic
([#491](#491))
([cb394f3](cb394f3))
* **eth-sender:** Correct ABI for get_verification_key
([#445](#445))
([8af0d85](8af0d85))
* **metadata-calculator:** Save commitment for pre-boojum
([#481](#481))
([664ce33](664ce33))
* Versioned L1 batch metadata
([#450](#450))
([8a40dc3](8a40dc3))
* **vm:** storage_refunds for `vm_refunds_enhancement`
([#449](#449))
([1e1e59f](1e1e59f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot pushed a commit that referenced this pull request Nov 16, 2023
…nt on main node (#504)

## What ❔

Support for `zks_getProof` was accedentally only implemented for WS apis
in #455, this PR deploys them also to HTTP endpoints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants